ewpt3ch/pkgstash
1
1
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fixed unhandled errors

Browse Source
This commit is contained in:
Eric Phillips
2026-05-26 09:12:55 -06:00
parent e22124dcf1
commit 08d6833c1f
1 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/cache/refresh.go
Vendored
+13 -4
View File
@@ -29,6 +29,7 @@ func (c *Cache) FetchDB(repo string) error {
slog.Info("fetch returned", "url", url, "status", resp.StatusCode) slog.Info("fetch returned", "url", url, "status", resp.StatusCode)
return &UpstreamError{StatusCode: resp.StatusCode} return &UpstreamError{StatusCode: resp.StatusCode}
} }
//nolint:errcheck //best effort
defer resp.Body.Close() defer resp.Body.Close()
tmpPath := dbPath + ".tmp" tmpPath := dbPath + ".tmp"
@@ -38,17 +39,25 @@ func (c *Cache) FetchDB(repo string) error {
} }
if _, err := io.Copy(tmpFile, resp.Body); err != nil { if _, err := io.Copy(tmpFile, resp.Body); err != nil {
tmpFile.Close() if err := tmpFile.Close(); err != nil {
c.cr.Remove(tmpPath) slog.Error("failed to close file", "file", tmpPath, "err", err)
}
if err := c.cr.Remove(tmpPath); err != nil {
slog.Error("failed to remove file", "file", tmpPath, "err", err)
}
return err return err
} }
if err := tmpFile.Close(); err != nil { if err := tmpFile.Close(); err != nil {
c.cr.Remove(tmpPath) if err := c.cr.Remove(tmpPath); err != nil {
slog.Error("failed to remove file", "file", tmpPath, "err", err)
}
return err return err
} }
if err := c.cr.Rename(tmpPath, dbPath); err != nil { if err := c.cr.Rename(tmpPath, dbPath); err != nil {
c.cr.Remove(tmpPath) if err := c.cr.Remove(tmpPath); err != nil {
slog.Error("failed to remove file", "file", tmpPath, "err", err)
}
slog.Error("failed to move tmpfile to permanent file", "file", tmpFile, "err", err) slog.Error("failed to move tmpfile to permanent file", "file", tmpFile, "err", err)
return err return err
} }